Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Skip cron-integration-test job in forked repo #3571

Closed
danhuawang opened this issue May 27, 2024 · 0 comments · Fixed by #3573
Closed

[Improvement] Skip cron-integration-test job in forked repo #3571

danhuawang opened this issue May 27, 2024 · 0 comments · Fixed by #3573
Assignees
@danhuawang
Labels
0.5.1 Release v0.5.1 0.6.0 Release v0.6.0 improvement Improvements on everything

Comments

@danhuawang
Copy link
Contributor

What would you like to be improved?

Skip cron-integration-test job in forked repo by default

How should we improve?

Add the job ran condition in workflow YAML file
@danhuawang danhuawang added the improvement Improvements on everything label May 27, 2024
@danhuawang danhuawang self-assigned this May 27, 2024
@danhuawang danhuawang mentioned this issue May 27, 2024
Merged
jerryshao pushed a commit that referenced this issue May 27, 2024
@danhuawang
[#3571] fix(CI): Skip cron job in fork repo by default. (#3573)
844a8e6 
### What changes were proposed in this pull request?

Skip running cron-integration-test job in fork repo by default.

### Why are the changes needed?

Fix: #3571 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

Test on fork repo:

<img width="1504" alt="image"
src="https://github.com/datastrato/gravitino/assets/154112360/da9500ef-e4d8-4528-9730-922fbd4f3f95">
github-actions bot pushed a commit that referenced this issue May 27, 2024
@danhuawang @web-flow
[#3571] fix(CI): Skip cron job in fork repo by default. (#3573)
281c3fe 
### What changes were proposed in this pull request?

Skip running cron-integration-test job in fork repo by default.

### Why are the changes needed?

Fix: #3571 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

Test on fork repo:

<img width="1504" alt="image"
src="https://github.com/datastrato/gravitino/assets/154112360/da9500ef-e4d8-4528-9730-922fbd4f3f95">
@jerryshao jerryshao mentioned this issue May 27, 2024
Merged
jerryshao added a commit that referenced this issue May 27, 2024
@jerryshao @danhuawang
[#3571] fix(CI): Skip cron job in fork repo by default. (#3581)
c0d2a4b 
### What changes were proposed in this pull request?

Skip running cron-integration-test job in fork repo by default.

### Why are the changes needed?

Fix: #3571 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

Test on fork repo:

<img width="1504" alt="image"
src="https://github.com/datastrato/gravitino/assets/154112360/da9500ef-e4d8-4528-9730-922fbd4f3f95">

Co-authored-by: danhuawang <154112360+danhuawang@users.noreply.github.com>
@jerryshao jerryshao added 0.5.1 Release v0.5.1 0.6.0 Release v0.6.0 labels May 27, 2024
diqiu50 pushed a commit to diqiu50/gravitino that referenced this issue Jun 13, 2024
@danhuawang @diqiu50
[apache#3571] fix(CI): Skip cron job in fork repo by default. (apache…
4fc30e0 
…#3573)

### What changes were proposed in this pull request?

Skip running cron-integration-test job in fork repo by default.

### Why are the changes needed?

Fix: apache#3571 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

Test on fork repo:

<img width="1504" alt="image"
src="https://github.com/datastrato/gravitino/assets/154112360/da9500ef-e4d8-4528-9730-922fbd4f3f95">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danhuawang danhuawang

Labels
0.5.1 Release v0.5.1 0.6.0 Release v0.6.0 improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#3571] fix(CI): Skip cron job in fork repo by default. danhuawang/gravitino
2 participants
@jerryshao @danhuawang