Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] No authentication is required when accessing the path "/api/version". #3934

Closed
yuqi1129 opened this issue Jun 21, 2024 · 2 comments
Closed

[Improvement] No authentication is required when accessing the path "/api/version". #3934

yuqi1129 opened this issue Jun 21, 2024 · 2 comments
Assignees
@yuqi1129
Labels
improvement Improvements on everything

Comments

@yuqi1129
Copy link
Contributor

What would you like to be improved?

Path "/api/version" should be protected by user authentication by design, this should be done.

How should we improve?

No response
@yuqi1129 yuqi1129 added the improvement Improvements on everything label Jun 21, 2024
@yuqi1129 yuqi1129 mentioned this issue Jun 21, 2024
Merged
@FANNG1 FANNG1 closed this as completed in cc5e67b Jun 21, 2024
@FANNG1
Copy link
Contributor

FANNG1 commented Jun 21, 2024

@yuqi1129 , this issues seems couldn't be fixed by #3898, please check it.

@yuqi1129
Copy link
Contributor Author

@yuqi1129 , this issues seems couldn't be fixed by #3898, please check it.

Sorry, this issue is not a problem, I would close it.

mchades pushed a commit to mchades/gravitino that referenced this issue Jun 24, 2024
@yuqi1129 @jerryshao
[apache#3897] fix(python-test): Check Gravitino server status before …
c9ac6ea 
…running python test in embedded mode. (apache#3898)

### What changes were proposed in this pull request?

Add check logic to ensure that the Gravitino server is ready to serve. 

### Why are the changes needed?

To make the python integration-test more stable. 

Fix: apache#3897
Fix: apache#3832
Fix: apache#3934
### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

CI and test locally.
shaofengshi pushed a commit to shaofengshi/gravitino that referenced this issue Jun 24, 2024
@yuqi1129 @shaofengshi
[apache#3897] fix(python-test): Check Gravitino server status before …
793217b 
…running python test in embedded mode. (apache#3898)

### What changes were proposed in this pull request?

Add check logic to ensure that the Gravitino server is ready to serve. 

### Why are the changes needed?

To make the python integration-test more stable. 

Fix: apache#3897
Fix: apache#3832
Fix: apache#3934
### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

CI and test locally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuqi1129 yuqi1129

Labels
improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FANNG1 @yuqi1129