Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug report] version.ini is not packaged into Python dist package #3952

Closed
jerryshao opened this issue Jun 24, 2024 · 0 comments · Fixed by #3953
Closed

[Bug report] version.ini is not packaged into Python dist package #3952

jerryshao opened this issue Jun 24, 2024 · 0 comments · Fixed by #3953
Assignees
Labels
0.6.0 Release v0.6.0 bug Something isn't working

Comments

@jerryshao
Copy link
Contributor

Version

main branch

Describe what's wrong

Currently, the generated version.ini file is in the top level of the folder, not in the gravitino folder, so it will not be packaged into the gravitino dist package, and will be failed to find the file when running the code.

Below is the code stack

Error message and/or stacktrace

image

How to reproduce

Just package the gravitino python package, installed locally and use it will throw an exception.

Additional context

No response

@jerryshao jerryshao added the bug Something isn't working label Jun 24, 2024
jerryshao added a commit that referenced this issue Jun 26, 2024
…alling the package (#3953)

### What changes were proposed in this pull request?

Fix the issue of version.ini not found issue when installing python
gravitino package using pip and run.

### Why are the changes needed?

Previously, the `version.ini` file is under the project path, which will
not be included after installing the package using pip, so now module to
`graviitino` folder.

Fix: #3952

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Exisiting tests.
@jerryshao jerryshao self-assigned this Jun 26, 2024
@jerryshao jerryshao added the 0.6.0 Release v0.6.0 label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.6.0 Release v0.6.0 bug Something isn't working
Projects
None yet
1 participant