[#27] feat(core): add config system #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryshao
changed the title
jerryshao
changed the title
jerryshao
changed the title
|
@xunliu please help to review when you have time, thanks a lot. |
xunliu
previously approved these changes
May 29, 2023
Let me think about how to add a such unit test. |
|
@xunliu I added a new test to cover loading from file, please review again, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR introduces a Spark-style like strong typed config system for the project.
Why are the changes needed?
The config system is a cornerstone of the project. By comparing different config system implementations, Spark's one is strong type verified, and also can extend to other functions, so introducing a Spark-style like config system for the project.
Fix: #27
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
Add new UTs to cover the test