Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3336] improvement(test): make docker detection failure error messages more clear #3542

Commits on May 24, 2024

  1. [#3336] improvement(test): make docker detection failure error messag…

    …es more clear (#3538)
    
    ### What changes were proposed in this pull request?
    
     - clarify OrbStack status
     - check the docker env before IT start
    
    ### Why are the changes needed?
    
    The previous detection logic was located in the constructor, and when
    the test failed, it would throw an exception
    `ExceptionInInitializerError`, causing the original error to be covered.
    
    Fix: #3336 
    
    ### Does this PR introduce _any_ user-facing change?
    
    no
    
    ### How was this patch tested?
    
    Locally, by hand
    mchades authored and web-flow committed May 24, 2024
    Configuration menu
    Copy the full SHA
    f5478ee View commit details
    Browse the repository at this point in the history