[#3897] fix(python-test): Check Gravitino server status before running python test in embedded mode. #3898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FANNG1
reviewed
Jun 20, 2024
xunliu
reviewed
Jun 20, 2024
| fun gravitinoServer(operation: String) { | ||
| val process = ProcessBuilder("${project.rootDir.path}/distribution/package/bin/gravitino.sh", operation).start() | ||
| val exitCode = process.waitFor() | ||
| if (exitCode == 0) { | ||
| val currentContext = process.inputStream.bufferedReader().readText() | ||
| if (operation == "start") { | ||
| waitForPort(8090) |
There was a problem hiding this comment.
Do we need to try to catch throw RuntimeException("Timed out waiting for port $port to be available") in here?
try {
waitForPort(8090)
}
catch Exception()....
There was a problem hiding this comment.
I have added the exception from lines 33 to 34.
FANNG1
reviewed
Jun 21, 2024
...ion-test-common/src/test/java/com/datastrato/gravitino/integration/test/util/AbstractIT.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jun 21, 2024
...ion-test-common/src/test/java/com/datastrato/gravitino/integration/test/util/AbstractIT.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jun 21, 2024
xunliu
reviewed
Jun 21, 2024
There was a problem hiding this comment.
Fix the Python issue, Why do we need to modify the java test code?
There was a problem hiding this comment.
I changed the logic regarding checking the Gravitino server from TCP to HTTP by the way
FANNG1
approved these changes
Jun 21, 2024
mchades
pushed a commit
to mchades/gravitino
that referenced
this pull request
Jun 24, 2024
…running python test in embedded mode. (apache#3898) ### What changes were proposed in this pull request? Add check logic to ensure that the Gravitino server is ready to serve. ### Why are the changes needed? To make the python integration-test more stable. Fix: apache#3897 Fix: apache#3832 Fix: apache#3934 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? CI and test locally.
shaofengshi
pushed a commit
to shaofengshi/gravitino
that referenced
this pull request
Jun 24, 2024
…running python test in embedded mode. (apache#3898) ### What changes were proposed in this pull request? Add check logic to ensure that the Gravitino server is ready to serve. ### Why are the changes needed? To make the python integration-test more stable. Fix: apache#3897 Fix: apache#3832 Fix: apache#3934 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? CI and test locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add check logic to ensure that the Gravitino server is ready to serve.
Why are the changes needed?
To make the python integration-test more stable.
Fix: #3897
Fix: #3832
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
CI and test locally.