Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add releases to the project #81

Closed
vasa-chi opened this issue Aug 8, 2014 · 14 comments
Closed

Please add releases to the project #81

vasa-chi opened this issue Aug 8, 2014 · 14 comments

Comments

@vasa-chi
Copy link

vasa-chi commented Aug 8, 2014

This project is listen in bower packages, but has no releases.

It is possible to put particular commit into bower.json dependencies, but it would be much better and more logical to have release tags.

@DataTables
Copy link
Collaborator

Yup good point. i'll look into that when I can.

@vasa-chi
Copy link
Author

vasa-chi commented Aug 8, 2014

Thank you :)

@CyborgMaster
Copy link

I would also very much appreciate this. We just started managing our front end packages inside of our Rails project using rails-assets.org, which packages bower packages as ruby gems. In order for the conversion process to work correctly, there must be official bower release tags for the project.

It should be very simple. We only need a basic bower.json and a version tag on the repo.

Thanks!

@X13454
Copy link

X13454 commented Sep 3, 2014

+1

@varemenos
Copy link

Please do this, we recently had issues due to updating dataTables-Plugins via bower.
Bower didn't match any release so it added an asterisk and pulled the latest commit which broke our UI.

I was forced to specify a commit id, so the project is stuck at that point of time until you guyz add releases (or until in the future I test and fix the UI for another future commit)

@margaritis
Copy link

👍

@DataTables
Copy link
Collaborator

I've just added tag 1.0.0 to the current HEAD of this repo. Each time I release to the DataTables CDN site I'll bump the patch number up by one. The minor number will be bumped if I do any major alterations to the layout for the repo and I think it is unlikely that the major version will ever change from 1.

I haven't added any JSON description files yet - that is still to do. but the tag is there at least :-)

@CyborgMaster
Copy link

Hey, that's good enough for what I need. This lets me use bower and rails-assets.org. Thank you!

I vote this issue be closed.

@varemenos
Copy link

@DataTables wouldn't it be better if the Plugins repo had the same version number as the DataTables repo's version number to represent which Plugins release is for which DataTables release?

@DataTables
Copy link
Collaborator

I suppose that is possible, but the plug-in version don't really map 1:1 with DataTables releases. For example the sorting and i18n plug-ins don't relate to DataTables versions at all (beyond their based need for DataTables).

Possibly I should match the main release versions - 1.x.

I'll certainly consider it - thanks for the input.

@arderyp
Copy link

arderyp commented Apr 25, 2017

whatever happened to datatables-plugins npm package? Would be a shame to require bower as a dependency just to grab that package there since it isnt in NPM. If I am missing something and it IS in NPM stored under some other name, please let me know.

EDIT: I see drmonty-datatables-plugins is available, but I think an official package would be much better

@DataTables
Copy link
Collaborator

I've created a datatables.net-plugins package on npm: https://www.npmjs.com/package/datatables.net-plugins .

What it is missing is a main file since it doesn't really make sense for this kind of repo. You would need to select the file that you want using the require statement.

@DataTables
Copy link
Collaborator

And now a bower file: https://github.com/DataTables/Plugins/blob/master/bower.json which is published to datatables.net-plugins as well.

Its taken an embarrassingly long time for me to do this. I've been wanted to do various other things for the packages, but haven't yet. This is a stop gap.

@arderyp
Copy link

arderyp commented Apr 27, 2017

YESS! that was super quick, thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants