Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock scroller when child rows are shown #58

Closed
prog8 opened this issue Oct 7, 2015 · 3 comments
Closed

Lock scroller when child rows are shown #58

prog8 opened this issue Oct 7, 2015 · 3 comments

Comments

@prog8
Copy link

prog8 commented Oct 7, 2015

In general child rows in datatables can be much larger (contains more data) than standard rows. This makes DT scroller break somehow. When I open child row which is very high and I scroll down to see the entire rows scroller starts it work and reloads the DT page. I think scroller should be locked in the same position page until all child rows are opened. Any opinions about this?

@DataTables
Copy link
Collaborator

I can't really see any way for Scroller to operate correctly with child rows. The issue is that Scroller needs to calculate the position of the table in the scrolling table, which it can only do is all rows are of an equal height and there are no extra elements. If you introduce child rows, then they would need to be taken into account, but that would make the calculations really rather difficult.

I'm afraid that this is not a feature than I am planning on adding to Scroller.

@prog8
Copy link
Author

prog8 commented Oct 7, 2015

I was wondering if it is possible to say "hold on scroller, child rows are opened now so lets freeze". I mean that scroller can be disabled temporarily when child rows are opened and can be enabled again if they are closed. Even if there is no direct support for child rows why cannot be a feature to temporarily disable scroller?

@DataTables
Copy link
Collaborator

As an end user I'm not sure I would like scrolling being disabled. Perhaps showing a modal rather than a child row would be an option? There is currently no API to enable and disable scroller - although you could use a little Javascript to disable scrolling if you wished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant