-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Message when copying to clipboard is an alert() instead of nicely styled message (as in TableTools 1) #2
Comments
Code used in TableTools 1.1.4: alert( 'Copied '+(aData.length-1)+' rows to the clipboard' ); Code used in TableTools 2.0.1: alert( 'Copied '+len+' row'+plural+' to the clipboard' ); There should be no changes to the alert style in TableTools. Might it be that you are using Firefox 4 now and seeing their new modal alert messages? |
Sorry, I was wrong about TableTools 1. I didn't realize that another developer on my team applied that change... I thought TT shipped that way. I think it's a worthwhile change, though, and easily done: just extract the print message code and call the same function when copying to the clipboard. |
That's an interesting idea. I've added it to my 'to-do' list to try implementing it and think about it a bit more. Nice suggestion - thanks! |
…as been generalised into fnInfo which will let any message be shown
Repro: Click on the copy button. You'll get a basic alert message telling you that rows have been copied to the clipboard. In TableTools 1, you got a nicely styled message just like the print button.
Not sure why was this behaviour changed in TableTools 2, but I prefer the previous implementation.
The text was updated successfully, but these errors were encountered: