Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readability by turning the configuration into a class #89

Closed
nabla-c0d3 opened this issue Jan 27, 2017 · 2 comments
Closed

Improve readability by turning the configuration into a class #89

nabla-c0d3 opened this issue Jan 27, 2017 · 2 comments
Milestone

Comments

@nabla-c0d3
Copy link
Member

Using a dictionary to store the configuration make it difficult to understand what information is stored in the configuration.

@nabla-c0d3 nabla-c0d3 added this to the 1.4.2 milestone Jan 28, 2017
@nabla-c0d3 nabla-c0d3 modified the milestones: 1.4.2, 1.5.0 Feb 21, 2017
@nabla-c0d3 nabla-c0d3 modified the milestones: 1.6.0, 1.5.0 Jun 22, 2017
@nabla-c0d3
Copy link
Member Author

nabla-c0d3 commented Jun 22, 2017

As this change is going to break the API anyway, we should also rename the constructors (init VS initialize), related types and variables (such as TSKPinningPolicy) to clarify what they are as "configuration" is a bit vague.

@nabla-c0d3 nabla-c0d3 modified the milestones: 1.5.0, 1.6.0 Jun 27, 2017
@nabla-c0d3
Copy link
Member Author

nabla-c0d3 commented Jun 27, 2017

The TKSDomainPinningPolicy type is now available (added in f3aea09 ), and should be enough, for now, to clarify what's in a pinning policy.
As long as we need to support the pinning policy being set from the Info.plist file, it will need to be defined in a way that's serializable (ie. a dictionary).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant