Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/cleanup executable builds #31

Merged
merged 18 commits into from Jul 15, 2021
Merged

Conversation

beesaycheese
Copy link
Contributor

@beesaycheese beesaycheese commented Jul 15, 2021

Change the name from annotator to portal
Bash jobs all exits when an error occurs
For the setup bash files, added a condition that checks for the necessary files that needs to be transferred to portal-build first
Pyinstaller error for macos
change python3 portal-build/portal.py to python3 portal.py

@beesaycheese
Copy link
Contributor Author

@marcus-neo I made some changes to run.py to accommodate for the scenario where the users use the command line to run python portal.py. Can you help me to check through that file please? Thank you!

Copy link
Contributor

@marcus-neo marcus-neo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run.py and init.py seems good to me :)

@gkeechin gkeechin merged commit b1fc921 into develop Jul 15, 2021
@marcus-neo marcus-neo deleted the hotfix/cleanup-executable-builds branch July 26, 2021 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants