Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambassador 0.50.0-ea5 upstream certs are offered to client #983

Closed
n1koo opened this issue Nov 19, 2018 · 2 comments
Closed

Ambassador 0.50.0-ea5 upstream certs are offered to client #983

n1koo opened this issue Nov 19, 2018 · 2 comments
Assignees
Milestone

Comments

@n1koo
Copy link
Contributor

n1koo commented Nov 19, 2018

Describe the bug
When using MTLS the certs that should be used for upstream are offered to the client.

Example config with Istio:

      apiVersion: ambassador/v0
      kind: Module
      name: tls
      config:
        server:
          enabled: true
          redirect_cleartext_from: 8080
          secret: ambassador-certs
        client:
          enabled: false
        upstream:
          cert_chain_file: /etc/istiocerts/cert-chain.pem
          private_key_file: /etc/istiocerts/key.pem

This is also somehow related to #981 , eg., if I remove redirect_cleartext_from: 8080 it works again. Doesn't matter if the http or https endpoint is hit.

To Reproduce
Add upstream certs, hit any TLS enabled endpoint

Expected behavior
server.secret should be used to match correct cert

Versions (please complete the following information):

  • Ambassador: 0.50.0-ea5
  • Bare metal Kubernetes 1.12.0

Additional context
Add any other context about the problem here.

@richarddli richarddli added this to the 0.50.0-ea7 milestone Nov 21, 2018
@concaf concaf self-assigned this Nov 29, 2018
@kflynn kflynn modified the milestones: 0.50.0-ea7, 0.50.0 GA Dec 7, 2018
@concaf
Copy link
Contributor

concaf commented Dec 19, 2018

@n1koo this should have been fixed in #1037 #1042, can you confirm?

@kflynn
Copy link
Member

kflynn commented Dec 20, 2018

Closing fixed in -rc1; @n1koo please reopen if you have trouble!

@kflynn kflynn closed this as completed Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants