Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gold file generation: emit kubectl stderr, so it's easier to debug #2998

Merged
merged 1 commit into from Oct 28, 2020
Merged

gold file generation: emit kubectl stderr, so it's easier to debug #2998

merged 1 commit into from Oct 28, 2020

Conversation

jwm
Copy link
Contributor

@jwm jwm commented Oct 1, 2020

Description

I was regenerating gold files as part of another PR, but all the gold file copies failed. This stops the gold file generator from hiding stderr, so it's easier to troubleshoot.

In my case, the problem is that gold file generation doesn't honor DEV_KUBECONFIG, and auth was failing against the (different) cluster described in my normal KUBECONFIG. It feels like fixing that is as easy as adding KUBECONFIG=$DEV_KUBECONFIG to the kubectl invocation here, but I wasn't sure if there were any other workflows that depend on the existing behavior.

Copy link
Member

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it. 🙂

@kflynn kflynn merged commit 8a27ce1 into emissary-ingress:master Oct 28, 2020
@jwm jwm deleted the jwm/let_goldfile_generation_stderr_out_of_the_bag branch January 6, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants