Add statsd prometheus mapping configurations #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeShu
pushed a commit
that referenced
this pull request
Mar 19, 2019
Add statsd prometheus mapping configurations
LukeShu
pushed a commit
that referenced
this pull request
Mar 31, 2019
Add statsd prometheus mapping configurations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently I maintain an alternate helm chart that allows me to configure how prometheus metrics are reported. By default every new service makes a new metric but I would prefer for all similar metrics to have the same name. Furthermore I wish for those metrics to contain a label that identifies which service it relates to. This is possible using a "mapping": https://github.com/prometheus/statsd_exporter/tree/v0.6.0#metric-mapping-and-configuration .
I am willing to maintain my own helm chart but I thought that this configuration option would be useful to others.
Major changes:
datawire/prom-statsd-exporter:0.6.0in favor ofprom/statsd-exporter:v0.6.0since we can specify command arguments in the helm chart.