Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usersvc2 service.py should listen on 127.0.0.1 #6

Open
gsacavdm opened this issue Nov 23, 2018 · 1 comment
Open

Usersvc2 service.py should listen on 127.0.0.1 #6

gsacavdm opened this issue Nov 23, 2018 · 1 comment

Comments

@gsacavdm
Copy link

gsacavdm commented Nov 23, 2018

The tutorial states, in order to prep for using Envoy:

Flask can go back to listening only on the loopback interface.

And that these changes are in usersvc2 however, that's not the case

app.run(host='0.0.0.0', port=5000, debug=True)

This line should be changes to listen on 127.0.0.1

PS: Nice tutorial!

@vishal-yadav
Copy link

I believe that's determined by below section for usersvc cluster for edge envoy vs service envoy. See host URL changed to localhost for service envoy version (usersvc2).

"clusters": [
  {
    "name": “usersvc”,
    ...
    "hosts": [
      {
        "url": “tcp://usersvc:80”
      }
    ]
  }
]
"clusters": [
  {
    "name": “usersvc”,
    ...
    "hosts": [
      {
        "url": “tcp://127.0.0.1:80”
      }
    ]
  }
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants