Updated to iOS 7.0 min deployment target #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: updated deployment target to iOS 7.0 (minimum to build with Xcode 9) feat: updated podspec's deployment target to iOS 7.0 (as Xcode's project)
|
Looks good to me! Thanks for your contribution! 👍 Also I can't believe this project started with a deployment target of 5.0... dang! |
|
Thanks! By the way, have you pushed the podspec to cocoapods? I´m trying to upgrade the pod to this last version 1.4.1, but it doesn't seem to find it |
4 tasks
alieltareb1
reviewed
Sep 22, 2022
| @@ -276,6 +276,7 @@ | |||
| GCC_PRECOMPILE_PREFIX_HEADER = YES; | |||
| s.summary = "Adds animated counting support to UILabel." | ||
| s.homepage = "https://github.com/dataxpress/UICountingLabel" | ||
| s.license = { :type => 'MIT', :file => 'LICENSE' } | ||
| s.author = { "Tim Gostony" => "dataxpress@gmail.com" } | ||
| s.source = { :git => "https://github.com/dataxpress/UICountingLabel.git", :tag => s.version.to_s } | ||
| s.ios.deployment_target = '5.0' | ||
| s.ios.deployment_target = '7.0' | ||
| s.tvos.deployment_target = '9.0' | ||
| s.source_files = 'UICountingLabel.{h,m}' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: removing a warning in a block declaration
feat: updated deployment target to iOS 7.0 (minimum to build without errors with Xcode 9)
feat: updated podspec's deployment target to iOS 7.0 (as Xcode's project)
When using this pod with a minimum target of iOS 10.0 and Xcode 9, the pod has 2 warnings, one about the block declaration not being a prototype.
The other one about
setAttributedText:which is only available in iOS 6.0 or newer.