Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relational.write - Special cases for Oracle and MSSql server #301

Closed
spicy-sauce opened this issue Apr 19, 2023 · 0 comments · Fixed by #304
Closed

relational.write - Special cases for Oracle and MSSql server #301

spicy-sauce opened this issue Apr 19, 2023 · 0 comments · Fixed by #304
Assignees
@vd2org
Labels
block bug Something isn't working

Comments

@spicy-sauce
Copy link
Member

spicy-sauce commented Apr 19, 2023 •
edited by vd2org
Loading

In Oracle, when DB is not available a sqlalchemy.exc.DatabaseError is thrown and not OperationalError.
We should catch this for Oracle only (as for other databases, this exception might be different or at least, need to check it, so you can catch them both together if this assumption is wrong).

For MSSql server OperationalError is thrown in some cases not related to connection.
@spicy-sauce spicy-sauce added bug Something isn't working block labels Apr 19, 2023
@vd2org vd2org changed the title relational.write - ConnectionError is not raised for Oracle relational.write - Special cases for Oracle and MSSql server Apr 19, 2023
@vd2org vd2org linked a pull request Apr 19, 2023 that will close this issue
relational.write: special cases for oracle and mssql server #304
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vd2org vd2org

Labels
block bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

relational.write: special cases for oracle and mssql server datayoga-io/datayoga
2 participants
@vd2org @spicy-sauce