Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt intergration-tests to run under docker #352

Closed
wheelly opened this issue Feb 1, 2024 · 3 comments
Closed

Adapt intergration-tests to run under docker #352

wheelly opened this issue Feb 1, 2024 · 3 comments
Assignees

Comments

@wheelly
Copy link
Collaborator

wheelly commented Feb 1, 2024

There is a half-ready implementations of dev folder which must be accompinied by README.md file.

  1. Resources/connections.yml must point to the right container addresses
  2. Remove
    xxx_container = redis_utils.get_redis_oss_container(redis_utils.REDIS_PORT) xxx_container.start()
    And stop at the end of the test
  3. Think about automatically start/restart container (they are all stateless) upon test start - maybe omitted for now
  4. Add README.md file
@wheelly wheelly self-assigned this Feb 1, 2024
@wheelly
Copy link
Collaborator Author

wheelly commented Feb 3, 2024

xxx_container = redis_utils.get_redis_oss_container(redis_utils.REDIS_PORT) xxx_container.start() - instead of removing maybe mock it with env variable not to do anything. Then the test will be intact. As to connections.yaml file - copy it to connections_docker.yaml and change all addresses there to point to the docker compose network domains.
The goal here is to be able after merging it to main to use it both in usual env (linux, WML) and in docker env

@wheelly
Copy link
Collaborator Author

wheelly commented Feb 3, 2024

@zalmane
# validate the connections connections_file = path.join(directory, "connections.yaml")
Can we add option for this file to be user defined? Like docker compose -f my_named_file.yaml

@wheelly wheelly closed this as completed Feb 4, 2024
@wheelly
Copy link
Collaborator Author

wheelly commented Feb 4, 2024

There is no time to mess with docker now since it appears there are drivers compiled for arm in wheel (pip)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant