Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scottish Gaelic locale issues #1913

Closed
leedriscoll opened this issue Aug 23, 2020 · 0 comments · Fixed by #1914
Closed

Scottish Gaelic locale issues #1913

leedriscoll opened this issue Aug 23, 2020 · 0 comments · Fixed by #1914

Comments

@leedriscoll
Copy link
Contributor

Since we've started using date-fns for Scottish Gaelic dates on the BBC News website in production. We've found a number issues that we need fixed.

1. 'o chionn' suffix to should actually be a prefix
11 diogan o chionn -> o chionn 11 diogan
1 diog o chionn -> o chionn 1 diog

2. We should be using the modern version of days / day
7 làithean o chionn -> o chionn 7 là
1 latha o chionn -> o chionn 1 là

3. Incorrect Seconds/Minutes/Hour for the 1, 2,20:
Seconds
20 diogan -> o chionn 20 diog
2 diogan -> o chionn 2 dhiog

Minutes
20 mionaidean o chionn -> o chionn 20 mionaid
2 mionaidean o chionn -> o chionn 2 mhionaid

Hours
20 uairean de thìde o chionn -> o chionn 20 uair de thìde
2 uairean de thìde o chionn -> o chionn 2 uair de thìde
1 uair o chionn -> o chionn 1 uair de thìde

4. Ordinal Indicators
1st – We've checked the latest guidance from the Gaelic Orthographic Conventions group and they have dropped the ‘c’ from
31st – works in the same way as 11th, so that should be be ‘31mh’
3rd – bundled it in with ‘mh’ so it now ‘3mh’, ‘13mh’, ‘23mh’.
12th – needs to be ‘12na’

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant