Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request — Allow setting custom business days #2085

Open
kamranahmedse opened this issue Nov 15, 2020 · 1 comment
Open

Feature Request — Allow setting custom business days #2085

kamranahmedse opened this issue Nov 15, 2020 · 1 comment

Comments

@kamranahmedse
Copy link

kamranahmedse commented Nov 15, 2020

Hey, first of all thank you for your work, really appreciate it!

Currently, there is no way to specify the business days for the isWeekend function. For example, the weekdays in UAE are Sunday to Thursday and so the output for the function is wrong.

Can we possibly make the weekdays configurable via an option?

@kossnocorp
Copy link
Member

I like this idea. I realize I'm late to the party, but it will be great to address it.

I'm unsure how to approach it, though, as business days aren't strictly related to a locale but rather a region. As someone who needed it, @kamranahmedse, can you please tell me how you approached it in your company? Knowing about the libraries, tools, and adjacent issues with regional standards will be helpful. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants