Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supported Versions of CKAN #31

Open
pdelboca opened this issue Dec 23, 2022 · 1 comment
Open

Supported Versions of CKAN #31

pdelboca opened this issue Dec 23, 2022 · 1 comment

Comments

@pdelboca
Copy link
Collaborator

CKAN has announced that they are in the process to release 2.10: https://ckan.org/blog/getting-ready-for-ckan-210

This release will include dropping support for 2.8. Also, support for Python 2.7 in extensions is gonna be dropped starting 2023.

Is the plan of this extension to continue providing support for 2.8 and Python 2.7?

I'm asking in the context of a migration of this extension to 2.10. Should a future PR keep supporting old versions or is it safe to drop it?

@jonathansberry
Copy link

Just to say we are also interested in getting this extension working with CKAN 2.10.

Aside from enabling the activity plugin in the test.ini, the only other matter I had to address to get all tests passing was a PyJWT version conflict between this extension and CKAN core. CKAN core is requiring a newer version of the dependancy. With the newer CKAN core version installed the following line breaks in the tests:

return jwt.decode(token, None, verify=False, algorithms=['none'])

This is because verify=False is a deprecated kwarg, in favour of the newer options={'verify_signature': False}, replacing one with the other gets the tests passing again.

Will you be releasing a CKAN 2.10 compatible version of this extenion in the near future? Would you welcome a PR for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants