You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.
Currently, if you try and push excel file and define non-existing sheet it will not fail and push data from the first sheet of excel file.
Another problem is that if you select even existing sheet, it'd push the first one, which means we're not able to push a sheet other than first one.
Reproduce
Try to push excel file with 2 sheets named sheet1 and sheet2. The following command will push the data from the first sheet
run data push myexcel.xlsx --sheets=3
run data push myexcel.xlsx --sheets=2
run data push myexcel.xlsx --sheets=1,2
run data push myexcel.xlsx --sheets=all
Expected behaviour
If sheet does not exist should terminate process and tell me about it
If sheet exists it should push that one
Dependencies
issue in data-cli
issue in datahub-clinet etc
The text was updated successfully, but these errors were encountered:
TESTED:
If an empty sheet is pointed by user, the program will reply with > Error! You cannot push an empty sheet. Please, add some data and try again.
FIXED.
@AcckiyGerman this is not about pushing empty sheet but pushing non-existing sheet. Eg: I have excel file with 2 sheets and trying to push 4th sheet data push my.xlsx --sheets=4 - Are you sure it's fixed?
@zelima yes, I tested with --sheets=5000 --sheets=all --sheets=1,2 --sheets=2,3 --sheets=all
etc
with an empty xlsx file and xlsx file with three sheets, where 1,3 has data, 2 is empty
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Currently, if you try and push excel file and define non-existing sheet it will not fail and push data from the first sheet of excel file.
Another problem is that if you select even existing sheet, it'd push the first one, which means we're not able to push a sheet other than first one.
Reproduce
Try to push excel file with 2 sheets named
sheet1
andsheet2
. The following command will push the data from the first sheetdata push myexcel.xlsx --sheets=3
data push myexcel.xlsx --sheets=2
data push myexcel.xlsx --sheets=1,2
data push myexcel.xlsx --sheets=all
Expected behaviour
Dependencies
data-cli
The text was updated successfully, but these errors were encountered: