Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline blockquotes support #42

Open
olayway opened this issue Jul 16, 2022 · 3 comments
Open

Multiline blockquotes support #42

olayway opened this issue Jul 16, 2022 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@olayway
Copy link
Member

olayway commented Jul 16, 2022

In Obsidian, you can create multiline blockquotes by returning at the end of the first line and starting the next one with > (which is added automatically in Obsidian by hitting enter while being on the end of the first line.)

Raw example:

> Roses are red,
> violets are blue.

How it renders in Obsidian:
image

How it renders here on GitHub:

Roses are red,
violets are blue.

How it renders in Flowershow:
image

What works

Adding two spaces at the end of the first line.

Raw example:

> Roses are red,  
> violets are blue.

How it renders in Obsidian:
image

How it renders here on GitHub:

Roses are red,
violets are blue.

How it renders in Flowershow:
image

@olayway olayway added the enhancement New feature or request label Jul 16, 2022
@rufuspollock
Copy link
Member

That is correct (commonmark) markdown if no trailing space on first line. For github flavored markdown it should though not sure about how the gfm support in remark works.

Rose are red
Violets are blue

A proper test would be the following which i think works.

> Rose are red
>
> Violets are blue

Rose are red

Violets are blue

Aside: good to add an example of the docs page for the relevant feature and see what happens.

@olayway
Copy link
Member Author

olayway commented Jul 18, 2022

A proper test would be the following which i think works.

> Rose are red
>
> Violets are blue

Rose are red

Violets are blue

But the above lines end up separated by an additional empty line...

Since we are mostly targetting Obsidian users, I think this is worth taking into account how it works in Obsidian. (+ it seems to work the same here on GitHub, although I couldn't find confirmation for this in the GFM spec).

Aside: good to add an example of the docs page for the relevant feature and see what happens.

I've noticed it while working on such a page (demo for markdown/obsidian syntax support), but I'll add a link here after merge. But I've just updated the description of this issue, so should be more clear what happens.

@rufuspollock rufuspollock added the good first issue Good for newcomers label Aug 16, 2022
@Gutts-n
Copy link
Contributor

Gutts-n commented Sep 19, 2023

@olayway in tests here, it looks like it's working correctly, am I right?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: 🆕 New
Development

No branches or pull requests

3 participants