Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filenames not handled by basic streaming transfer adapter #67

Closed
jonathansberry opened this issue Feb 15, 2021 · 3 comments
Closed

Filenames not handled by basic streaming transfer adapter #67

jonathansberry opened this issue Feb 15, 2021 · 3 comments

Comments

@jonathansberry
Copy link
Contributor

jonathansberry commented Feb 15, 2021

Context: We are looking to set giftless up to work with ckanext-blob-storage.

Problem: Basic streaming with local storage does not currently handle the desired download file names or file types correctly. Instead all files, irrespective of type are downloaded as ".html".

Observations: I can see that the file names with extension are passed to the batch request by ckanext-blob-storage, but this is simply dropped by the basic streaming transfer adaptor. I can't see anywhere where the Content-Type is passed from blob storage to giftless though.

Solution: We're very happy to help with this if you think that is constructive. I can submit a small PR for your review. Whether or not you use the PR (I really don't mind), I'd still really value the process of digging around giftless and hearing your feedback and thoughts.

@jonathansberry jonathansberry changed the title Filename not configured for basic streaming transfer adapter Filenames not handled by basic streaming transfer adapter Feb 15, 2021
@shevron
Copy link
Contributor

shevron commented Feb 16, 2021

Thanks for reporting - and thanks for the PR! I'll be more than happy to review. Will look into it and reply there.

@shevron
Copy link
Contributor

shevron commented Feb 16, 2021

As suggested on the PR, let's open a separate ticket for handling Content-type and discuss possible solutions there.

@shevron
Copy link
Contributor

shevron commented Feb 24, 2021

Resolved by #68

@shevron shevron closed this as completed Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants