Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to monorepo #38

Closed
12 of 13 tasks
rufuspollock opened this issue Jul 20, 2020 · 3 comments
Closed
12 of 13 tasks

Convert to monorepo #38

rufuspollock opened this issue Jul 20, 2020 · 3 comments
Assignees
Projects

Comments

@rufuspollock
Copy link
Member

rufuspollock commented Jul 20, 2020

With addition of create-portal-app it makes sense to move to a monorepo setup.

We will use yarn workspaces and, possibly in future, Lerna.

Acceptance

  • What is currently in root is in packages/portal
  • Have root readme (symlinked from packages/portal)
  • Have root package.json setup
  • Have lerna setup

Tasks

  • Create packages
  • Move current code into packages/portal
    • Keep tests in one central location at root (a la next.js)?
  • Root setup
    • Create a root package.json in wordspace mode
    • Symlink the README frompackages/portal into the root
  • Check everything passes
    • Fix test links

FUTURE

  • ? move components out of portal into portal-components package (or even split them up more)

Analysis

@abhishekgahlot abhishekgahlot self-assigned this Jul 21, 2020
@abhishekgahlot abhishekgahlot added this to Prioritized in v1 Overview via automation Jul 21, 2020
@abhishekgahlot abhishekgahlot moved this from Prioritized to In progress in v1 Overview Jul 21, 2020
@rufuspollock rufuspollock moved this from In progress to Prioritized in v1 Overview Jul 21, 2020
@abhishekgahlot abhishekgahlot moved this from Prioritized to In progress in v1 Overview Jul 22, 2020
@rufuspollock
Copy link
Member Author

@abhishekgahlot will complete by friday COP.

@abhishekgahlot abhishekgahlot moved this from In progress to In Review in v1 Overview Aug 17, 2020
@rufuspollock
Copy link
Member Author

@abhishekgahlot please can you update this!

@abhishekgahlot
Copy link
Contributor

@rufuspollock This is merged and needs to be closed.

v1 Overview automation moved this from In Review to Done Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v1 Overview
  
Done
Development

No branches or pull requests

2 participants