Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic Hero component #958

Merged
merged 1 commit into from Jun 20, 2023
Merged

Add basic Hero component #958

merged 1 commit into from Jun 20, 2023

Conversation

olayway
Copy link
Member

@olayway olayway commented Jun 20, 2023

Component API:

interface HeroProps {
    title: string;
    subtitle?: string;
    announcement?: {
        title: string;
        href?: string;
    };
    buttons?: Array<Button>
}

interface Button {
    title: string;
    href: string;
    type: 'filled' | 'text'
}

With Flowershow's light theme:
image

With Flowershow's dark theme:
image

@changeset-bot
Copy link

changeset-bot bot commented Jun 20, 2023

🦋 Changeset detected

Latest commit: c4bf5bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@portaljs/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

9 Ignored Deployments
Name Status Preview Updated (UTC)
portaljs-alan-turing ⬜️ Ignored (Inspect) Jun 20, 2023 1:56pm
portaljs-ckan ⬜️ Ignored (Inspect) Jun 20, 2023 1:56pm
portaljs-ckan-ssg ⬜️ Ignored (Inspect) Jun 20, 2023 1:56pm
portaljs-fivethirtyeight ⬜️ Ignored (Inspect) Jun 20, 2023 1:56pm
portaljs-git-example ⬜️ Ignored (Inspect) Jun 20, 2023 1:56pm
portaljs-learn ⬜️ Ignored (Inspect) Jun 20, 2023 1:56pm
portaljs-openspending ⬜️ Ignored (Inspect) Jun 20, 2023 1:56pm
portaljs-storybook ⬜️ Ignored (Inspect) Jun 20, 2023 1:56pm
site-portaljs ⬜️ Ignored (Inspect) Jun 20, 2023 1:56pm

@olayway
Copy link
Member Author

olayway commented Jun 20, 2023

@rufuspollock Is this what you wanted?

@rufuspollock
Copy link
Member

@olayway perfect - i assume if i leave off announcement it doesn't show.

@rufuspollock rufuspollock merged commit f96fb56 into main Jun 20, 2023
10 checks passed
@rufuspollock rufuspollock deleted the bespoke-hero branch June 20, 2023 15:32
Copy link
Member

@rufuspollock rufuspollock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olayway
Copy link
Member Author

olayway commented Jun 20, 2023

@olayway perfect - i assume if i leave off announcement it doesn't show.

Yes, it's optional. The only required thing is the main title.

@github-actions github-actions bot mentioned this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants