Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone/Pull triggers a file watch event on source #628

Closed
joehand opened this issue Feb 7, 2017 · 3 comments
Closed

Clone/Pull triggers a file watch event on source #628

joehand opened this issue Feb 7, 2017 · 3 comments

Comments

@joehand
Copy link
Collaborator

joehand commented Feb 7, 2017

Share a NEW Dat on one terminal:

mkdir share-dir
echo "hello" > share-dir/hola.txt
DEBUG=dat,dat-node dat share ./share-dir

Clone the new Dat on another one:

dat clone <link> down-dir

You'll see the files watch trigger when then clone connects:

  dat Imported /Users/joe/Desktop/share-dir/hola.txt +24ms
  dat Import finished +0ms
  dat Network: first peer connected +10s
  dat File watch updated: hola.txt +0ms
  dat Imported /Users/joe/Desktop/share-dir/hola.txt +2ms
  dat File updated: hola.txt +0ms

So it seems like a remote download is affecting the source file. May be related to #626 and #623.

PR #627 fixes this by not importing the files again, but still is an issue.

@joehand
Copy link
Collaborator Author

joehand commented Feb 7, 2017

Looks like the PR doesn't totally fix it. I was able to get it to happen again by adding a third connection.

@joehand
Copy link
Collaborator Author

joehand commented Feb 7, 2017

Fixed by not downloading content as source.

@joehand joehand closed this as completed Feb 7, 2017
@okdistribute
Copy link
Collaborator

woot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants