Support pkg #849
Support pkg #849
Conversation
|
Should be able to use travis to automatically create releases: https://docs.travis-ci.com/user/deployment/releases/. Looking into it... |
| skip_join: true | ||
| on_success: change | ||
| on_failure: always | ||
|
|
||
| deploy: |
There was a problem hiding this comment.
trying to figure it out =)
- package binary with
pkg(npm run package) - travis automatically builds after tests pass
- uploads to github releases
I don't see the result of this last build anywhere though. Not sure how it works without the tags.
| }, | ||
| "pkg": { | ||
| "assets": [ | ||
| "node_modules/utp-native/prebuilds/**", |
There was a problem hiding this comment.
Why double * when globbing?
There was a problem hiding this comment.
I think that means it is recursive but I don't really know what I'm doing
There was a problem hiding this comment.
Found an explanation here https://github.com/sindresorhus/globby#globbing-patterns , apparently ** is inclusive of / and * is not https://github.com/sindresorhus/multimatch/blob/master/test/test.js#L38
|
Does Are you intend to use as executable app bundler, e.g. when used on android as a replacement for node-on-android? Can |
|
I dont think it does but tree shaking mostly helps with reducing sizes when
you frameworks (things that export more than one function) which we don't
really use in our stack
…On Tue, Aug 15, 2017, 06:57 Arnold Schrijver ***@***.***> wrote:
Does pkg also do bundle optimization such as the tree shaking in rollup?
https://github.com/rollup/rollup#tree-shaking
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#849 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAW_VZT7tSbO-1q7HmUy1X-aqkQKWeCPks5sYXmdgaJpZM4O1P8w>
.
|
|
I was trying to run rollup to see what it does, but it cannot bundle this project by default because it uses |
No description provided.