Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Discussion: timestamps in hyperdb #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bnewbold
Copy link
Contributor

Rendered pre-merge

Proposes including "event" timestamps at the hyperdb abstraction layer for every change to the database.

I suspect @mafintosh would prefer doing this at the highest abstraction level as possible (eg, at hyperdrive, not hyperdb or hypercore), but i'm curious what others think, and whether this would be valuable at all.

Before seriously reviewing to merge as Draft, I would want to demonstrate working code and have a better idea what the API would look like, but this is otherwise pretty flushed out.

@pfrazee
Copy link
Contributor

pfrazee commented Mar 18, 2018

I dont have much to say except I'm +1 the premise and my gut reaction is that hyperdb is the right place for this (not hypercore).

@bnewbold
Copy link
Contributor Author

This got discussed here: mafintosh/hyperdb#97 (comment)

With the new hyperdb deleted flag, even a deletion node can contain a value. This means that a higher-level application can include a timestamp in every hyperdb value/node.

I still think a timestamp might be "special" enough of a form of metadata to be included in the hyperdb Entry protobuf schema as an optional field, but I don't feel particularly urgent about it. Going to let this DEP PR linger, but wouldn't oppose closing it if we do a garbage collection at some point.

@pfrazee
Copy link
Contributor

pfrazee commented Jun 10, 2018

I'd like to have the timestamps personally, but I don't have a pressing need for it yet.

@martinheidegger
Copy link
Contributor

Referencing: mafintosh/append-tree#16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants