Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

create a plugin for the pre-commit framework #217

Closed
eyarz opened this issue Oct 20, 2021 · 4 comments · Fixed by #225
Closed

create a plugin for the pre-commit framework #217

eyarz opened this issue Oct 20, 2021 · 4 comments · Fixed by #225
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers WIP Working in progress (will be deployed soon)
Projects

Comments

@eyarz
Copy link
Member

eyarz commented Oct 20, 2021

Is your feature request related to a problem? Please describe.
Sharing Datree's pre-commit hooks across projects can be painful because it requires copying and pasting unwieldy bash scripts.

Describe the solution you'd like
The pre-commit framework was created to solve those hook issues.

Additional context
Creating new hooks.
Related to #125

@eyarz eyarz added enhancement New feature or request good first issue Good for newcomers labels Oct 20, 2021
@kevholmes
Copy link
Contributor

Hi there! I've set up pre-commit hooks and worked with custom hooks before for a number of projects and really like it. I'd like to take a look into this.

@eyarz
Copy link
Member Author

eyarz commented Oct 21, 2021

@kevholmes go for it :)

@eyarz eyarz added the WIP Working in progress (will be deployed soon) label Oct 21, 2021
@romanlab romanlab added this to To do in Datree via automation Oct 21, 2021
@kevholmes
Copy link
Contributor

kevholmes commented Oct 21, 2021

If I wanted to add some documentation on how to use the pre-commit hook where might be a good place? @eyarz

@eyarz
Copy link
Member Author

eyarz commented Oct 22, 2021

Unfortunately, the docs are not open source (the platform that I'm using is not supporting it 😞), so just add your instructions to your PR and I will copy it from there (just like you did).

@romanlab romanlab moved this from To do to Selected for development in Datree Oct 26, 2021
@dimabru dimabru assigned dimabru and unassigned dimabru Oct 31, 2021
Datree automation moved this from Selected for development to Done Nov 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers WIP Working in progress (will be deployed soon)
Projects
Development

Successfully merging a pull request may close this issue.

4 participants