Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add navlink active #30

Merged
merged 6 commits into from Apr 12, 2022
Merged

Add navlink active #30

merged 6 commits into from Apr 12, 2022

Conversation

daudi13
Copy link
Owner

@daudi13 daudi13 commented Apr 12, 2022 •
edited

In this project, I:

  • Added class active to nav links to highlight which page a user is on
  • Added responsiveness to the navbar
  • Added responsiveness to the navlinks
  • Fixed the proptype issue from the previous PR

@daudi13 daudi13 requested a review from Ismailco April 12, 2022 04:52
Ismailco
Ismailco approved these changes Apr 12, 2022
View reviewed changes
Copy link
Collaborator

@Ismailco Ismailco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @daudi13,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

@daudi13 daudi13 merged commit 35ff4d3 into development Apr 12, 2022
@daudi13 daudi13 deleted the Add-Navlink-Active branch April 12, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ismailco Ismailco Ismailco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daudi13 @Ismailco