Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use ABI to detect number endian in then database #15

Closed
moteus opened this issue Oct 4, 2018 · 2 comments
Closed

Do not use ABI to detect number endian in then database #15

moteus opened this issue Oct 4, 2018 · 2 comments

Comments

@moteus
Copy link
Contributor

moteus commented Oct 4, 2018

I have system where I have ffi.abi('le') false, but mmdb file has such endian.
So as result I have wrong value in record_size.
I suggest detect endian based on e.g. IP version format. It can be either 6 or 4.
@moteus moteus closed this as completed Oct 4, 2018
@daurnimator
Copy link
Owner

Did anything need to be done here?

@moteus
Copy link
Contributor Author

moteus commented Oct 5, 2018

No. It was as broken ffi implementation which always return false on ffi.abi.
I just change condition from ffi.abi('le') to not ffi.abi('be') :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daurnimator @moteus