Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] allow to render multi-line text in listview entries #1072

Closed
fogine opened this issue Mar 19, 2020 · 7 comments
Closed

[REQUEST] allow to render multi-line text in listview entries #1072

fogine opened this issue Mar 19, 2020 · 7 comments

Comments

@fogine
Copy link
Contributor

fogine commented Mar 19, 2020

It would be great if rofi supported rendering of multi-line strings in listview elements with Pango markup.
Currently all text is stuffed into single line and a new line escape sequence \n is used as delimiter for new elements.

This would enable for showing more data to user per entry.
A new option for declaring custom delimiter would have to be added.

My use case is that I need to show search results to the user where each listview entry has title,link and description sections which wouldn't fit into a single line (and even if it did, it would be hard to navigate through data)

rofi 1.5.4

@DaveDavenport
Copy link
Collaborator

DaveDavenport commented Mar 19, 2020

related to #1069

@fogine
Copy link
Contributor Author

fogine commented Mar 19, 2020

I forgot to mention that I'd like to use it with custom -modi plugin that allows me to update listview data in realtime - somewhat related to #1041

@DaveDavenport
Copy link
Collaborator

So if #1041 is implemented this one is also resolved?

@fogine
Copy link
Contributor Author

fogine commented Mar 31, 2020

Well, I'm reading the referenced issue again with rofi documentation.
The referenced issue talks about support for for -sep and -eh for rofi script mode which I now understand is not the same as c plugins...

We need to push script modes to level of feature closer to C plugins.

It's not clear to me what is the current state of script mode.

I don't use the special rofi script mode currently, my intention is to use rofi-blocks for more advance use cases. So it would be ideal if rofi supported Pango markup and line height (multi-line text) rendering everywhere.

@DaveDavenport
Copy link
Collaborator

Rofi does support markup (just about everywhere) and line heigh. So not sure where things are missing.
(no idea if rofi-blocks supports it).

@fogine
Copy link
Contributor Author

fogine commented Mar 31, 2020

You are right, -eh option and pandoc markup work for c plugins.
I got confused because at first I could not find the option for setting line height in man pages and then I saw that it's broken in the referenced issue and thought it's dmenu only option.

I created pull request that adds the option to the man pages.

So this is no longer an issue.
This makes me excited! Thanks :)

@fogine fogine closed this as completed Mar 31, 2020
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants