Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle ellipize #917

Closed
vredesbyyrd opened this issue Feb 16, 2019 · 5 comments
Closed

Toggle ellipize #917

vredesbyyrd opened this issue Feb 16, 2019 · 5 comments
Milestone

Comments

@vredesbyyrd
Copy link

vredesbyyrd commented Feb 16, 2019

Version

1.5.2

Configuration

gist

Launch Command

rofi -show top -modi top

Steps to reproduce

  • launch rofi
  • arrow right to view truncated text

What behaviour you see

  • No change

What behaviour you expect to see

  • Ability to view text that has been truncated by dynamically changing the ellipses. Beginning, middle(?) & end. Shift the entire view with a hotkey.

Further Details

Being able to dynamically change the windows view in order to view truncated lines would be a nice feature. Basically, functioning left/right keys. I know this is a great example of something being easier said than done, and their being a lot to consider. Although I stumbled on #399 which has the same end goal and mentions this patch, which I unsuccessfully tried to apply. I am assuming it won't build since rofi's code has evolved so much since then.

My question: if I went through line by line and manually added the contents of that patch where its needed, could i get the keybinding and behavior to "toggle ellipsis"? Or has rofi's code base changed so much that the patch is now obsolete?

I am using rofi as a narrow sidebar that displays screen right, and with certain scripts and plugins I use having the ability to toggle between a lines beginning and end could be helpful, e.g how I prefer to display rofi_top:

Any thoughts on accomplishing this would be appreciated. Thanks for your time.

rofi-2019-02-15-1926-00000

@DaveDavenport DaveDavenport added the Incomplete Report - Please follow the guidelines Your report is incomplete and does not follow the guidelines, you may not expect an answer label Feb 16, 2019
@DaveDavenport DaveDavenport removed the Incomplete Report - Please follow the guidelines Your report is incomplete and does not follow the guidelines, you may not expect an answer label Mar 4, 2019
@DaveDavenport
Copy link
Collaborator

The patch won't work anymore. Rofi code base has been in flux a lot.
I can see a use for this, will add it to the todo.

@DaveDavenport DaveDavenport added this to the 1.5.3 milestone Mar 4, 2019
@vredesbyyrd
Copy link
Author

That is awesome to hear. Thanks for the followup.

@DaveDavenport
Copy link
Collaborator

Implemented, Should be bound to Alt+period.

@vredesbyyrd
Copy link
Author

Just did some lite testing on commit 52c5592 and it seems to be working great :)

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants