Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improving performance] Using the style.fontSize and style.width #83

Closed
wants to merge 3 commits into from

Conversation

saintclair
Copy link

Through the use of native features js good performance is proven;

Compare performance (style):

fontSize: http://jsperf.com/resizers
**(new) > width: http://jsperf.com/jquery-css-vs-width-vs-native-width/2

@davatron5000
Copy link
Owner

Soo... this doesn't work at all. 😞 $this[0].style.width returns an empty string. and parseInt($this[0].style.width) returns NaN.

You really need to test the code you're commiting against example.html instead of making assumptions.

@saintclair
Copy link
Author

Sorry if this was the scope would have to create a variable, then returned with $ this.width () will create the pull request now

@davatron5000
Copy link
Owner

:rage2: Still doesn't work.

@saintclair
Copy link
Author

just a few more minutes I'm evaluating return in a few moments

@saintclair
Copy link
Author

new version, sorry rework, pull request created, performed tests on the console is not informed any more error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants