Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Words with H1 tags #17

Closed
ghost opened this issue Apr 18, 2011 · 10 comments
Closed

Words with H1 tags #17

ghost opened this issue Apr 18, 2011 · 10 comments

Comments

@ghost
Copy link

ghost commented Apr 18, 2011

Hey guys, I could just be missing something here, but I'm trying to use the lettering words method with an H1 tag. It only is allowing me to manipulate each letter and not the whole word. I switched it to a paragraph tag and it works. I would rather have the site's main title in an H1 tag. Any suggestions?

I'm using this:

$(document).ready(function() {
$(".headline").lettering('words');
});

@davatron5000
Copy link
Owner

I was able to create a little working version over on JSFiddle: http://jsfiddle.net/dSDvr/
It should work on a h1 no problem, and we've had no problems in the past.

Maybe post/test your code on JSFiddle.

@ghost
Copy link
Author

ghost commented Apr 19, 2011

hmmm, it is now also altering other paragraphs even though they do not have the same class.

@davatron5000
Copy link
Owner

I'd have to see some HTML to verify how its being used, it's a little too mysterious right now.

@lukeholder
Copy link

The example at http://jsfiddle.net/dSDvr/ given above - which is meant to be proof that it works with h1 - fails, in that it does not color any words when tested in internet explorer 9 on windows 7.

The default (plain lettering) also fails on a h1 within ie9 on windows 7, see here:
http://jsfiddle.net/dSDvr/8/

Any question let me know...

@davatron5000
Copy link
Owner

@lukeholder can you post a screenshot of what you're seeing?

Also, is this site failing? http://lostworldsfairs.com/atlantis/
Reason being that Lettering was actually built out for IE9, so it should handle it just fine.

Sorry to make you do the legwork, my Win machine is completely exploded at the moment.

@davatron5000
Copy link
Owner

Thanks so much for posting those. Very weird.

My last test would be to try a different version of jQuery. Googling around I found some issues filed on jQuery 1.5.2 for IE9 (http://bugs.jquery.com/ticket/8052) which might be affected by jQuery.

Let me know if that fixes it and if so I'll make a note that Lettering requires jQuery 1.6+

@ghost
Copy link
Author

ghost commented Jul 16, 2011

Hey Dave, yeah I just updated to the newest version of JQ for my newest project, and it fixed the problem. Thanks!

@lukeholder
Copy link

newer jquery fixes for me also.

@davatron5000
Copy link
Owner

huzzah! I'll add a note about minimum requirements over on the Readme & Wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants