New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility improvements #38
Comments
Working demo: http://codepen.io/davatron5000/full/pxoKf Uses Downsides: Duplicates DOM nodes could have SEO impact. Ideally, ARIA would provide a way for semantic elements that are |
@davatron5000 |
Either way, it make for a much better experience when using Assistive Technology. I think the little amount of SEO impact you would have would be so small, that @davatron5000's solution would be worth it. |
@bassettsj WOOO. GREAT. I forked your pen b/c it wasn't working for me, but this looks like an infinitely better way to do this. With mine, I was hesitant about duplicating content, but your way preserves it all. I was also hesitant about breaking the Document Outline, but running it through VoiceOver & ChromeVox makes me think it'll hold together nicely. Wonderful work. If you want to put together a commit and get the credit, I'll merge it in. |
Accessibility improvements were merged in and are apart of the 🎆 🏆 👯 |
Lettering.js is inaccessible due to screen readers pausing at every HTML tag, including inline
span
tags.A possible fix might be something along the lines of:
Haven't tested it in case some one wants to pick it up. The screen reader should skip over the
aria-hidden
and read theclone
.The text was updated successfully, but these errors were encountered: