Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let reviewers specify minimum star rating for coders #22

Open
davearonson opened this issue Apr 29, 2013 · 2 comments
Open

Let reviewers specify minimum star rating for coders #22

davearonson opened this issue Apr 29, 2013 · 2 comments

Comments

@davearonson
Copy link
Owner

As a reviewer,
I want to specify a minimum rating for the authors of PRs I will review,
So I don't have to wade through crappy code.

Given that there are PRs submitted by one-, two- and three-star coders,
And I am otherwise eligible to review all of them,
When I specify a minimum star rating of two stars,
Then I will not see the PRs from one-star coders.

(This might be a Premium feature.)

@cupakromer
Copy link

Is there a way this could be integrated into the PR comments? Maybe look for some term followed by one or more 👍

@davearonson
Copy link
Owner Author

I don't understand what you mean. Can you sketch out the relevant parts of the workflow, and where stars/thumbs/whatever would come into play?

(And I just noticed that, in contradiction to my earlier statement of not wanting to nail down ratings to a specific style quite yet, I have done so already. Oh well.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants