Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLs must be for Github PRs #5

Closed
davearonson opened this issue Apr 23, 2013 · 3 comments
Closed

URLs must be for Github PRs #5

davearonson opened this issue Apr 23, 2013 · 3 comments

Comments

@davearonson
Copy link
Owner

As a user,
I want to have other users limited to putting in valid Github pull request URLs,
So that I can find actual PRs instead of spam.

Given that I am on the New Pull Request page,
When I enter a URL that is NOT for a Github pull request,
And I submit it,
Then I should get an error message
And the URL should not be in the system.

Given that I am on the New Pull Request page,
When I enter a URL that IS for a Github pull request,
And I submit it,
Then I should NOT get an error message
And the URL should be in the system.

@ghost ghost assigned davearonson Apr 23, 2013
@davearonson
Copy link
Owner Author

Added a regex-based validation, and test with a canonical and an invalid url.

@davearonson
Copy link
Owner Author

Duh, should also test w/ some other good formats, and maybe give some instruction.

@davearonson
Copy link
Owner Author

Done. Still not accepting w/o a protocol on them tho. Most will probably be cut and pasted from browser address bars, and should thus have protocols.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant