Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

joNavbar can't be extended #49

Open
ukabu opened this issue Aug 24, 2011 · 1 comment
Open

joNavbar can't be extended #49

ukabu opened this issue Aug 24, 2011 · 1 comment
Assignees
Milestone

Comments

@ukabu
Copy link

ukabu commented Aug 24, 2011

There is an issue with joNavbar that prevent it from being extended (subclassed).

The listener for the back button is a function called back. But in the constructor function, it is replaced by the back property which hold the reference to the joBackButton.

The code works because when adding the event listener, the reference to the function has not be called yet, but this cause issues when extending the joNavbar.

The listener should be named goBack instead of back (or any other name that is not back).

@davebalmer
Copy link
Owner

Good catch! Moving this weekend, will get on it next week unless someone else gets to it first.

@ghost ghost assigned davebalmer Dec 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants