Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update XGBoost 1.4.2 #14

Merged
merged 12 commits into from Oct 1, 2021
Merged

Conversation

vaaaaanquish
Copy link
Collaborator

@vaaaaanquish vaaaaanquish commented Sep 26, 2021

@davechallis @jonathanstrong Hi.

Overview

Requires

This PR requires the following merge

Confirmed that example/runall.sh is working.

$ head xgboost-sys/xgboost/NEWS.md
XGBoost Change Log
==================

This file records the changes in xgboost library in reverse chronological order.

## v1.4.2 (2021.05.13)

$ ./runall.sh
...
Compiling xgboost-sys v0.2.0 (/app/rust-xgboost/xgboost-sys)
...

Description

@vaaaaanquish vaaaaanquish changed the title [WIP] Update XGBoost 1.4.2 Update XGBoost 1.4.2 Sep 28, 2021
@vaaaaanquish
Copy link
Collaborator Author

@davechallis @jonathanstrong Hi.

Please review this PR and davechallis/xgboost#1

I've prepared a Dockerfile to run these.

FROM rust

WORKDIR /app
RUN apt update &&\
    rm -rf ~/.cache &&\
    apt clean all
RUN apt install -y cmake libclang-dev libc++-dev gcc-multilib libssl-dev

RUN git clone --recursive https://github.com/vaaaaanquish/rust-xgboost.git
RUN cd rust-xgboost &&\
    git checkout release_1.4.2 &&\
    cd xgboost-sys/xgboost &&\
    git remote add upstream https://github.com/vaaaaanquish/xgboost.git &&\
    git fetch upstream &&\
    git submodule deinit -f rabit &&\
    git rm -f rabit &&\
    git stash &&\
    git checkout upstream/release_1.4.2 &&\
    cd dmlc-core &&\
    git pull origin master
RUN sed -i -e 's/xgboost-sys.*/xgboost-sys\={path\="\.\/xgboost-sys"}/g' /app/rust-xgboost/Cargo.toml

WORKDIR /app/rust-xgboost
ENTRYPOINT [ "/bin/bash" ]

It works with the following command :)

$ docker build -t example .
$ docker run -it example

# cargo test
# cd examples
# ./runall.sh

@davechallis davechallis merged commit 20104e1 into davechallis:master Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to use XGBoost 1.0.0
2 participants