Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change types for some TreeBoosterParameters to match types in XGBoost #9

Merged
merged 2 commits into from Oct 1, 2021

Conversation

KyussCaesar
Copy link
Contributor

While working on a personal project using this repo I noticed that some of the types for the parameters in TreeBoosterParameters don't seem to match up with what's in XGBoost? You can check them out here.

Changelog

  • Change types for a few TreeBoosterParameters to match types in XGBoost:
    • gamma: u32 -> f32
    • min_child_weight: u32 -> f32
    • max_delta_step: u32 -> f32
    • lambda: u32 -> f32
    • alpha: u32 -> f32
  • Add some missing parameters:
    • colsample_bynode: Subsample columns for each split.
    • num_parallel_tree: Number of trees to train in parallel ("boosted random forest")
  • Change updater parameter to only pass a value if user specifies one (fix: Incorrect sequence of updaters #7)
  • Add impls of From<String> and From<&str> for TreeMethod.
  • Removed some muts to suppress compiler warnings.

I'm keen to hear feedback on the changes for the updater parameter; the main design goal for the change was "make the warning message go away", so would not be surprised if my changes aren't the best way of handling things.

Closes #7

@davechallis davechallis merged commit e6c8707 into davechallis:master Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect sequence of updaters
2 participants