Change types for some TreeBoosterParameters
to match types in XGBoost
#9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on a personal project using this repo I noticed that some of the types for the parameters in
TreeBoosterParameters
don't seem to match up with what's in XGBoost? You can check them out here.Changelog
TreeBoosterParameters
to match types in XGBoost:gamma
:u32
->f32
min_child_weight
:u32
->f32
max_delta_step
:u32
->f32
lambda
:u32
->f32
alpha
:u32
->f32
colsample_bynode
: Subsample columns for each split.num_parallel_tree
: Number of trees to train in parallel ("boosted random forest")updater
parameter to only pass a value if user specifies one (fix: Incorrect sequence of updaters #7)impl
s ofFrom<String>
andFrom<&str>
forTreeMethod
.mut
s to suppress compiler warnings.I'm keen to hear feedback on the changes for the
updater
parameter; the main design goal for the change was "make the warning message go away", so would not be surprised if my changes aren't the best way of handling things.Closes #7