Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the number of 30x follows #49

Closed
jrozner opened this issue Sep 25, 2016 · 2 comments
Closed

Limit the number of 30x follows #49

jrozner opened this issue Sep 25, 2016 · 2 comments

Comments

@jrozner
Copy link
Contributor

jrozner commented Sep 25, 2016

Introduce the -max-directs flag from curl to limit the maximum number for 30x redirects to follow and set a sane default. cURL sets this to 50.

@davecheney
Copy link
Owner

Does this need to be configurable? Can't we just make an arbitrary decision, say 10 and leave it at that?

I don't want to end up rewriting all of curl.

On 25 Sep. 2016, at 17:39, Joe Rozner notifications@github.com wrote:

Introduce the -max-directs flag from curl to limit the maximum number for 30x redirects to follow and set a sane default. cURL sets this to 50.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@jrozner
Copy link
Contributor Author

jrozner commented Sep 25, 2016

Sure, but the only additional change to support arbitrary numbers would be adding a flag to change the default number. Also, with the proposed features (not counting all the non HTTP(S) features of cURL that nobody uses) it's not going to be that far off from a functional re-implementation of cURL anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants