Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing source code for TournamentModule.dll for BWAPI version 4.2.0 #12

Closed
chriscoxe opened this issue Aug 19, 2017 · 9 comments
Closed

Comments

@chriscoxe
Copy link
Contributor

The source code is missing for TournamentModule.dll for BWAPI version 4.2.0, i.e. the file bwapi-data/TournamentModule.dll contained in server/required/Required_BWAPI_420.zip. For the other versions it is located at e.g. src/tournamentmodule/BWAPI_412

Please could it be added? The reasons are for transparency and because I would like to build my own variant of TournamentModule.dll for BWAPI 4.2.0 that runs on Windows XP SP3 (FYI, BWAPI 4.2.0 doesn't work on Windows XP SP3 and I've already proposed a fix to BWAPI in bwapi/bwapi#733). Thanks

@chriscoxe chriscoxe changed the title Source code missing for TournamentModule.dll for BWAPI version 4.2.0 Missing source code for TournamentModule.dll for BWAPI version 4.2.0 Aug 19, 2017
@davechurchill
Copy link
Owner

I believe it's identical to the 4.1.2 version, just compiled in 4.2.0, but @richard-kelly could you add it?

@richard-kelly
Copy link
Collaborator

@davechurchill that's correct. I'll create a version named 4.2.0 for clarity.

@chriscoxe
Copy link
Contributor Author

chriscoxe commented Aug 23, 2017

Thanks, please feel free to close this issue. I just successfully used it to build and test my own variant of TournamentModule.dll for a modified version of BWAPI 4.2.0 that runs on Windows XP SP3.

Note: the injectory.x86.exe file included in StarcraftAITournamentManager doesn't run on Windows XP SP3 (due to the same issue described in bwapi/bwapi#733) but I was able to use Chaoslauncher instead with an old version of the StarcraftAITournamentManager JAR files.

@davechurchill
Copy link
Owner

We should just update the instructions to say Windows 7

@chriscoxe chriscoxe reopened this Aug 23, 2017
@chriscoxe
Copy link
Contributor Author

Sorry, closed by misclick.

@chriscoxe
Copy link
Contributor Author

By the way, the stuff about Windows XP SP3 was just FYI - I wasn't pushing for Windows XP SP3 support.

@davechurchill
Copy link
Owner

I just think that advertising Windows 7 is the easiest option rather than worrying about XP versioning :)

@davechurchill
Copy link
Owner

@richard-kelly Has this been added? If so can you close the issue

@richard-kelly
Copy link
Collaborator

Yes, the change was made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants