Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments on recent patches #70

Closed
ajaybhargav opened this issue Nov 22, 2016 · 3 comments
Closed

Comments on recent patches #70

ajaybhargav opened this issue Nov 22, 2016 · 3 comments
Labels

Comments

@ajaybhargav
Copy link
Contributor

I have added some comments on recent patches:
@679004914fceb1c418545fb33c707fb454cbc4bb
@b88da9b0ded73bf63fd11e589b52d9cf1e95f7d8

Please take a look at that.

@FSMaxB
Copy link
Collaborator

FSMaxB commented Nov 22, 2016

@ajaybhargav
Copy link
Contributor Author

I understand the reason for not using stdbool.h But I still have doubts on initializing variables. I still feel its unnecessary. You can close this issue (question) if you feel.

@FSMaxB
Copy link
Collaborator

FSMaxB commented Nov 22, 2016

I prefer the small chance that this might prevent a programming error in the future or an exploit from happening over not having these few additional instructions.

I will close this for now. I will reconsider if more people start complaining.

@FSMaxB FSMaxB closed this as completed Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants