Skip to content
This repository has been archived by the owner on Oct 18, 2020. It is now read-only.

Add Laravel 5.8 support #203

Merged
merged 5 commits into from
Feb 27, 2019
Merged

Add Laravel 5.8 support #203

merged 5 commits into from
Feb 27, 2019

Conversation

dabich
Copy link
Contributor

@dabich dabich commented Feb 26, 2019

No description provided.

@d13r
Copy link
Owner

d13r commented Feb 26, 2019

Tests seem to be failing so I can't merge it - but not just in the latest version, so I'm not sure why - but I don't have time to investigate right now.

README.md Outdated Show resolved Hide resolved
@ammonkc
Copy link

ammonkc commented Feb 26, 2019

I'm not sure if this is what's causing it to fail, but the deprecated array_first() helper method is being use here:
https://github.com/davejamesmiller/laravel-breadcrumbs/blob/8e2ddef22bc0451f7b1df714c0de3c8ec20ec843/src/BreadcrumbsManager.php#L282

It should probably be updated to Arr::first()

According to the Laravel docs this helper method is deprecated:

All array_* and str_* global helpers have been deprecated. You should use the Illuminate\Support\Arr and Illuminate\Support\Str methods directly.

@d13r
Copy link
Owner

d13r commented Feb 26, 2019

It should probably be updated to Arr::first()

Good idea.

@lloricode
Copy link

phpunit setUp() and tearDown() need to add return type :void

@KubqoA
Copy link

KubqoA commented Feb 27, 2019

I think it isn't enough to just rollback the version of phpunit to 7 while leaving the void return type intact in the setup methods. I feel like you need to modify that as well. I would do it myself but I don't have the write privileges.

@d13r
Copy link
Owner

d13r commented Feb 27, 2019

Good catch on the .travis.yml file. I'm just running some local tests then will merge & release it. Thanks!

@d13r d13r merged commit 720b4cc into d13r:master Feb 27, 2019
@d13r
Copy link
Owner

d13r commented Feb 27, 2019

All done.

@dabich dabich deleted the laravel-5.8 branch February 28, 2019 09:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants