Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count key to category endpoint #29

Closed
matheusfelipeog opened this issue Jan 20, 2022 · 4 comments
Closed

Count key to category endpoint #29

matheusfelipeog opened this issue Jan 20, 2022 · 4 comments

Comments

@matheusfelipeog
Copy link
Contributor

Hi @davemachado ;)

I'm a maintainer of the public-apis project and I was thinking of showing the number of categories at the top of README.md in the same way we show the number of APIs:

image

But only the category endpoint doesn't have the count key in its return, I think this might be a nice addition.

Example:

{
    "count": 51,
    "categories": [
        "Animals",
        "Anime",
        ...
        "Video",
        "Weather"
    ]
}
@davemachado
Copy link
Owner

Hey @matheusfelipeog , thanks for bringing this up!

This definitely sounds like a nice addition. I've added this to my backlog for the week and should get to it over the next few days :)

@matheusfelipeog
Copy link
Contributor Author

Hey @matheusfelipeog , thanks for bringing this up!

This definitely sounds like a nice addition. I've added this to my backlog for the week and should get to it over the next few days :)

Perfect 😄

@davemachado
Copy link
Owner

@matheusfelipeog b90cc8e is now deployed, so you should be good to go!

 ~ $ curl https://api.publicapis.org/categories | jq | head
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   785  100   785    0     0  11056      0 --:--:-- --:--:-- --:--:-- 11056
{
  "count": 51,
  "categories": [
    "Animals",
    "Anime",
    "Anti-Malware",
    "Art & Design",
    "Authentication & Authorization",
    "Blockchain",
    "Books",
    ```

@matheusfelipeog
Copy link
Contributor Author

@matheusfelipeog b90cc8e is now deployed, so you should be good to go!

Very good, great work @davemachado ❤️

A big THANK YOU for implementing this. Now everyone can see the number of categories easily:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants