New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Plus Codes #27
Conversation
…hods for other geometries
…ment-pluscodes
…oncode import into separate function (davemlz#23)
…ersion function that handles nested coordinates. Make pluscodes plural where relevant. Modify the pluscode tests to ensure that pluscodes returned by ee.Geometry.plusCodes and ee.Feature.plusCodes can be used as geometry constructors. (davemlz#23)
Hi, @aazuspan! Sorry for the late response and thank you for the PR! I hope to start reviewing it today and let you know how things are going! |
Hi, @aazuspan. Question here, is it required some sort of authentication for using openlocationcode? |
Hi @davemlz, the openlocationcode package doesn't require any authentication. It just runs a pretty simple algorithm to convert Plus Codes to longitude/latitude coordinates and vice versa, totally offline. |
Hi, @aazuspan! I don't know what's happening with the automatic testing. But it seems that it is required to have your own EE token in the forked repository. Please do the following: In the repository, please go to Settings > Secrets > New repository secret. In that window, please fill the Name of the secret as EE_TOKEN, and in the Value, please check your EE credentials file. It is usually in the users root of your local machine: "./.config/earthengine/credentials". In that file you will find the Then, please update your branch since I have modified some files, I think there are not conflicts, but just to be sure! Then I'll re-run the test checks! I hope that will solve the problem! |
Hi @davemlz, I've added the refresh token to my fork. Hopefully that fixes the issue! |
Hi, @aazuspan! I don't know why the checks are not working yet. Let me check if I can find the problem. If not, I will clone your fork and run the tests from local to see what's happening. I'll let you know! |
Sounds good, let me know if there's anything I can do on my end! |
Hi, @aazuspan! I've tried your fork in local and the tests are in perfect conditions! I still don't know why the checks are not working, so, let's do this: Since the tests are perfectly working, I can merge the PR! :) Just some points:
Tutorial created by: Aaron Zuspan I think that's all! Let me know :) |
Thanks @davemlz! I've updated and added a tutorial. Should be good to merge now if the tutorial looks okay! |
Hi, @aazuspan! Everything was perfect and your branch has been merged! Thank you very much for contributing to eemont! |
Implements #23 by adding the following features: