Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValueError break with lxml 3.5.0 #14

Closed
daveschaefer opened this issue Dec 13, 2015 · 2 comments
Closed

ValueError break with lxml 3.5.0 #14

daveschaefer opened this issue Dec 13, 2015 · 2 comments
Assignees
Labels

Comments

@daveschaefer
Copy link
Owner

In lxml 3.5.0 the searching behaviour was changed to explicitly reject None type namespace mappings. From the changelog: "Empty prefixes are explicitly rejected when a namespace mapping is used with ElementPath to avoid hiding bugs in user code"[1]

This breaks checkloc because it's currently using the dynamically generated namespace mappings generated by the root; this causes the namespace dictionary to contain a None entry.

Reported under danwent/Perspectives#166

[1] http://lxml.de/3.5/changes-3.5.0.html

@daveschaefer daveschaefer self-assigned this Dec 13, 2015
@daveschaefer
Copy link
Owner Author

The fix for this is simple - we can just explicitly use only the namespace(s) we need.

@daveschaefer
Copy link
Owner Author

Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant