Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curation of metadata created by mergeDims #42

Open
davestanley opened this issue May 10, 2017 · 0 comments
Open

Curation of metadata created by mergeDims #42

davestanley opened this issue May 10, 2017 · 0 comments

Comments

@davestanley
Copy link
Owner

When the user calls mergeDims, it creates the following metadata. This metadata might be used later on when unmergeDims is subsequently called.

obj.axis_pr(dims2merge(1)).axismeta.premerged_values = temp;
obj.axis_pr(dims2merge(1)).axismeta.premerged_names = mergednames;

Presently, operations such as obj.subset or obj.merge (or even subsequent calls to mergeDims) will not actively curate this metadata.

We should update the getters and setters (or other data that interacts with obj.axis) in order to actively curate these or, alternatively, return a warning to the user when they become misaligned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant